Cannot write mode RGBA as JPEG

[denning]

Related to https://github.com/python-pillow/Pillow/issues/2609 ?

What happened:

• Tried to add watermark as JPG or PNG through Django admin on local server. Produced 500 error.
• Reproduced on Photologue demo site: http://www.django-photologue.net/admin/photologue/watermark/

System Info:

• Python 3.6.3
• Django 2.0.1
• Photologue 3.8.1
• Pillow 5.0.0

Error Message:

Internal Server Error: /admin/photologue/watermark/add/
OSError at /admin/photologue/watermark/add/
cannot write mode RGBA as JPEG
...
File "/home/dylan/.virtualenvs/project/lib/python3.5/site-packages/PIL/JpegImagePlugin.py" in _save
605.         rawmode = RAWMODE[im.mode]

[richardbarran]

I've just pushed a commit to the master branch with a possible fix - could you try it out please and let me know if it works?

[denning]

Wow thanks for quick response!! 👍 👍

Steps taken

• Updated requirements.txt -> git+https://github.com/jdriscoll/django-photologue.git@9a2331e74095536a34e0a2eb7be2d5ef4fcb0cf3
• Pushed to remote server
• Added new JPG watermark through admin (successfully!)
• Added new PNG watermark through admin (successfully!)
• Attempted to change watermark through 'photo sizes' admin -> both producing 500 error.

Traceback (truncated)

File "/home/dylan/.virtualenvs/project/lib/python3.5/site-packages/PIL/JpegImagePlugin.py" in _save
  605.         rawmode = RAWMODE[im.mode]

...

File "/home/dylan/.virtualenvs/project/lib/python3.5/site-packages/django/contrib/admin/options.py" in save_model
  1026.         obj.save()

File "/home/dylan/.virtualenvs/project/lib/python3.5/site-packages/photologue/models.py" in save
  839.         self.clear_cache()

File "/home/dylan/.virtualenvs/project/lib/python3.5/site-packages/photologue/models.py" in clear_cache
  827.                     obj.create_size(self)

File "/home/dylan/.virtualenvs/project/lib/python3.5/site-packages/photologue/models.py" in create_size
  439.             raise e

File "/home/dylan/.virtualenvs/project/lib/python3.5/site-packages/photologue/models.py" in create_size
  433.                         optimize=True)

File "/home/dylan/.virtualenvs/project/lib/python3.5/site-packages/PIL/Image.py" in save
  1930.             save_handler(self, fp, filename)

File "/home/dylan/.virtualenvs/project/lib/python3.5/site-packages/PIL/JpegImagePlugin.py" in _save
  607.         raise IOError("cannot write mode %s as JPEG" % im.mode)

[richardbarran]

Hi - sorry for taking a long time to get back to you. I've pushed another commit to the master branch which fixes the second issue that you reported - well, it fixes it for me! Can you try it out please?

[denning]

[Edited after uninstalling and reinstalling patch to server.]

Thank you!!!! Tested on local and remote servers - worked perfectly.

So sorry for the long delay! Once again, thank you so much for your work! :+1:

[richardbarran]

Great to hear that this issue has been fixed!