search

richardbarran / django-photologue

A customizable plug-in photo gallery management application for the Django web framework.
BSD 3-Clause "New" or "Revised" License
674 stars 239 forks source link

Swapped sortedm2m to sorted-m2m for Django 2.2 #200

Closed mina-gaid closed 5 years ago

mina-gaid commented 5 years ago

Fixed TypeError issue caused by django-sortedm2m by replacing it with a Django 2.2 supported fork

coveralls commented 5 years ago

Coverage Status

Coverage remained the same at 67.009% when pulling 9a6224ab1ae85c37459ccce8ec6d2058a90a2ba9 on mina-gaid:patch-1 into 60dc6473c4438e9051bdc5ec730d47c97c2eeb43 on richardbarran:master.

richardbarran commented 5 years ago

Hi Mina, Thanks for the pull request. I'd like to avoid swapping packages, if possible, as it will confuse users. I see that there's been movement on the django-sortedm2m project, but it seems to have stalled. I will take a look and see if I can help move it along. So I will keep your PR as an option, but I'd prefer to stay with the existing package if possible.

richardbarran commented 5 years ago

django-sortedm2m has finally been updated to be compatible with Django 2.2. I've update Photologue (version 3.10) to use the latest release of django-sortedm2m. So this PR is no longer required - but thanks for pushing this change forward.