Convert to RGB mode only on jpeg save

richardbarran / django-photologue

A customizable plug-in photo gallery management application for the Django web framework.

BSD 3-Clause "New" or "Revised" License

674 stars 239 forks source link

Convert to RGB mode only on jpeg save #201

Closed drazenzen closed 4 years ago

drazenzen commented 4 years ago

Creating PNG image sizes with transparency (RGBA image mode) will fail since alpha channel will be removed from image. Convert image to RGB mode only if image format is JPEG

coveralls commented 4 years ago

Coverage increased (+0.09%) to 67.331% when pulling 6d4bf1cbcae4e2e899b78ddb90f8885d7c66b07e on drazenzen:drop-alpha-on-jpeg-save-only into 23c437652c1d279434e2ae449399c125aa2ea892 on richardbarran:master.

richardbarran commented 4 years ago

Looks goods to me - thanks for the contribution! Just one comment: Photologue only supports Python 3 now, so you can write super() - no arguments required.