richardbarran / django-photologue

A customizable plug-in photo gallery management application for the Django web framework.

BSD 3-Clause "New" or "Revised" License

674 stars 239 forks source link

Add Django 4.0 support #220

Closed MartijnVerkleij closed 2 years ago

MartijnVerkleij commented 2 years ago

Hi there!

Today I tried to update my project to Django 4.0 but found out that Photologue is currently not compatible with it.

I have tried getting it to work by myself for now.

Unfortunately, since I develop on Windows for the time being I cannot run the complete Tox test suite. (I had a friend of mine run the 3.10 test suite on his machine and that passed fully, so I do not foresee issues for now.)

Is there anything else I need to prepare? Please let me know!

codecov-commenter commented 2 years ago

Codecov Report

Merging #220 (e23786c) into master (97768fe) will not change coverage. The diff coverage is 12.50%.

@@           Coverage Diff           @@
##           master     #220   +/-   ##
=======================================
  Coverage   69.58%   69.58%           
=======================================
  Files          16       16           
  Lines        1062     1062           
=======================================
  Hits          739      739           
  Misses        323      323

Impacted Files	Coverage Δ
photologue/admin.py	`65.64% <12.50%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 97768fe...e23786c. Read the comment docs.

richardbarran commented 2 years ago

Hi! Thanks for the contribution - it's looking good. I've tested it on my machine and everything works (including Tox). To make this a really great PR, could I ask you to remove from the CI/tox the Python and Django versions that are no longer supported (e.g. I noticed Django 3.1 but it's no longer supported). There might be others. Thanks in advance.

MartijnVerkleij commented 2 years ago

Hi there, Good to hear it works alright.

I checked both Django and Python out and removed python 3.6, and Django 3.1 like you already suggested. Python 3.7 will still be supported for quite a while (2023-06-27) so no worries there. However, Django 2.2 will only be supported until April this year. So that will have to be removed in the near future.

richardbarran commented 2 years ago

I've merged your code - many thanks for your PR! I will release a new version of Photologue shortly with your changes.