richardbarran / django-photologue

A customizable plug-in photo gallery management application for the Django web framework.
BSD 3-Clause "New" or "Revised" License
674 stars 239 forks source link

Watermark.image upload_to should use os.path.join or Pathlib. #224

Closed iarp closed 1 year ago

iarp commented 1 year ago

https://github.com/richardbarran/django-photologue/blob/master/photologue/models.py#L742

upload_to=PHOTOLOGUE_DIR + "/watermarks"

That should be using os.path.join or pathlib.

PHOTOLOGUE_DIR = pathlib.Path(env.str('DJANGO_PHOTOLOGUE_DIR'))
web_1  |   File "/usr/src/app/garden/models.py", line 10, in <module>
web_1  |     from photologue.models import ImageModel as BasePhotologueImageModel
web_1  |   File "/usr/local/lib/python3.9/site-packages/photologue/models.py", line 740, in <module>
web_1  |     class Watermark(BaseEffect):
web_1  |   File "/usr/local/lib/python3.9/site-packages/photologue/models.py", line 742, in Watermark
web_1  |     upload_to=PHOTOLOGUE_DIR + "/watermarks")
web_1  | TypeError: unsupported operand type(s) for +: 'PosixPath' and 'str'
richardbarran commented 1 year ago

Should be fixed 🤞 by https://github.com/richardbarran/django-photologue/commit/7775e490f27c43663035b896c800a754bded2dc2