richardbeare / GeospatialStroke

18 stars 5 forks source link

API keys query #2

Closed richardbeare closed 5 years ago

richardbeare commented 6 years ago

Can we use a google private key and client ID with googleway/mapbox?

mdsumner commented 6 years ago

The same goes for the geocoding MMC and potentially calculating transport distance. VicData does supply all address locations, would it be in scope to obtain that data and use it rather than a geocoding service? (It's pretty tricky, matching by address string but I guess it makes the point that it's possible).

I think I managed to order the whole state address layer from the map interface, will pursue in https://github.com/SymbolixAU/GeospatialStroke/issues/3

https://www.data.vic.gov.au/data/dataset/address-vicmap-address

richardbeare commented 5 years ago

We could use HughParsonage's package: https://github.com/HughParsonage/PSMA.git. I haven't checked whether MMC is in there, but it probably is.

I was planning on using it in one of the following examples to sample random addresses.

mdsumner commented 5 years ago

I finally tried PSMA, this is what I get

PSMA::geocode(flat_number = NA_character_, 
               number_first = 246, street_name = "Clayton", street_type = "Road", 
              postcode = 3168L)
#   ordering  LATITUDE LONGITUDE
#1:        1 -37.92013  145.1211

I'd say it's definitely going to be worth requiring a key for Google geocoding, having to specify each component of the address is really painful, when google will take just about any string and return a region with uncertainty included.

I do have the Vicmap address data set but it's pretty painful to read and deal with so I think that's out.

GNtem2 commented 5 years ago

Dear Michael

it's strange. usually ggmap is reliable but I tried it last night after your email and today and it's not working

Thanh

Professor Thanh G Phan FRACP, PhD Hudson Institute Building, Level 3 Room L3.66 Office Number +61385722612 Github page: https://github.com/GNtem2 CTI Web page: https://www.monash.edu/medicine/scs/medicine/research/star/clin-trials-imaging-informatics Geospatial Analysis:https://www.monash.edu/medicine/scs/medicine/research/geospatial-analysis https://www.monash.edu/medicine/scs/medicine/research/geospatial-analysis

On Wed, 10 Oct 2018 at 21:39, Michael Sumner notifications@github.com wrote:

I finally tried PSMA, this is what I get

PSMA::geocode(flat_number = NAcharacter, number_first = 246, street_name = "Clayton", street_type = "Road", postcode = 3168L)# ordering LATITUDE LONGITUDE#1: 1 -37.92013 145.1211

I'd say it's definitely going to be worth requiring a key for Google geocoding, having to specify each component of the address is really painful, when google will take just about any string and return a region with uncertainty included.

I do have the Vicmap address data set but it's pretty painful to read and deal with so I think that's out.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/SymbolixAU/GeospatialStroke/issues/2#issuecomment-428524971, or mute the thread https://github.com/notifications/unsubscribe-auth/ARx2J067f_1ZhQWX90TuO4e5S6SCHinNks5ujc5rgaJpZM4XLuuM .

richardbeare commented 5 years ago

Lets see how convincing we can make it with the free developer keys.

I'll be using the PSMA package later, because it is nice for generating random addresses, but we definitely want to cover the various geocoding options from google and osm.

GNtem2 commented 5 years ago

I just realised that Google Map API have changed their policy. now they don't allow keyless entry

Thanh

Professor Thanh G Phan FRACP, PhD Hudson Institute Building, Level 3 Room L3.66 Office Number +61385722612 Github page: https://github.com/GNtem2 CTI Web page: https://www.monash.edu/medicine/scs/medicine/research/star/clin-trials-imaging-informatics Geospatial Analysis:https://www.monash.edu/medicine/scs/medicine/research/geospatial-analysis https://www.monash.edu/medicine/scs/medicine/research/geospatial-analysis

On Thu, 11 Oct 2018 at 15:49, Richard Beare notifications@github.com wrote:

Lets see how convincing we can make it with the free developer keys.

I'll be using the PSMA package later, because it is nice for generating random addresses, but we definitely want to cover the various geocoding options from google and osm.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/SymbolixAU/GeospatialStroke/issues/2#issuecomment-428819678, or mute the thread https://github.com/notifications/unsubscribe-auth/ARx2J-5BA5mUewiv7aVp-DyaKDwluHlRks5ujs3pgaJpZM4XLuuM .

gboeing commented 5 years ago

Yes, the google maps API now requires keys and offer everyone a $200 monthly credit I believe. No more free use beyond that.

richardbeare commented 5 years ago

How many of the examples can we set up effectively using osm services?

GNtem2 commented 5 years ago

I had a look at the paper in latex format. it's coming along. we need to have some further discussion to make it relevant to neurologists.