Closed mattansb closed 3 years ago
I believe the code to add support for special characters was @jonathon-love's - looping him in here to see if he has any insight.
hmm, let me take a look. as a general rule, any sort of unicode handling in R under windows is a mess.
i'm not sure this is related to my mods ... but i can't quite figure out where this data frame is constructed. could you point me in the right direction rich?
with thanks
i'm not sure this is related to my mods ... but i can't quite figure out where this data frame is constructed. could you point me in the right direction rich?
with thanks
Oh, I was just hoping you might see something obvious. I'll handle it for now and rope you back in if needed. I won't want to make a breaking change to JASP or jamovi, if this affects them.
This was fixed by you before, @jonathon-love, and just hasn't made it to CRAN yet! I fixed the other issue mentioned in the link as well and will push this new version out soon.
@richarddmorey Do you have a timeline in mind as to when you will be pushing this fix to CRAN
?
I am relying on the fixed version but can't push my package to CRAN
unless BayesFactor
's devel version is on CRAN
.
I mean I can cheat my way to it by skipping a few tests that rely on this fix, but that will be Plan B.
Unfortunately I'm deep in teaching right now. It is on the backburner and it could be some time in December. Sorry for the delay; I got a bunch of new teaching responsibilities this year.
Okay, no worries.
For now, I will use the workaround I mentioned and will have another release once BayesFactor
gets updated on CRAN
.
@richarddmorey Any plans for this update to hit CRAN any time soon?
Hi Richard, I was wondering the same thing as Mattan if an update will be heading to the CRAN soon.
Since over a year, we have been pretty much skipping the relevant tests and asking the users to update BayesFactor from GitHub, both of which are unfortunately not ideal. The bugs can get through in the former case, while beginners may just back off because they may not be comfortable in downloading a package from GitHub.
Thanks in advance for considering.
I just pushed the new version to CRAN; assuming no issues, it should be up soon.
Thanks @richarddmorey !
This causes issues on non-windows machines, but also makes it difficult to match posterior columns across models (both came up here: https://github.com/easystats/bayestestR/issues/345).
See example below:
But random effect column-names are fine from other models:
Created on 2020-10-15 by the reprex package (v0.3.0)