search

richarddmorey / BayesFactor

BayesFactor R package for Bayesian data analysis with common statistical models.
https://richarddmorey.github.io/BayesFactor/
131 stars 48 forks source link

Added 'tibble' handling #86

Closed jonathon-love closed 7 years ago

jonathon-love commented 7 years ago

fixes #67 fixes #80

richarddmorey commented 7 years ago

This is obviously the easiest way to do this, but because I don't use tbl_df I'm not sure whether this will yield unexpected behaviour in the conversion to a data.frame. I think we should at least note that something was done, in case there is a loss if information somewhere.

jonathon-love commented 7 years ago

yeah, makes sense. i was thinking "but tibbles are compatible with data frames in every way", but that's clearly not the case, otherwise we wouldn't be in this situation. what if i add a:

warning('data coerced from tibble to data frame')
richarddmorey commented 7 years ago

That would be ok I think.

jonathon-love commented 7 years ago

you hate tibbles?