Pretrain does not save the model.

richarddwang / electra_pytorch

Pretrain and finetune ELECTRA with fastai and huggingface. (Results of the paper replicated !)

325 stars 42 forks source link

Closed PhilipMay closed 3 years ago

PhilipMay commented 3 years ago

Hi,

I am starting a pretrain with just 100 iterations like so: learn.fit(9999, cbs=[lr_shedule])

But the model is not saved to './checkpoints/pretrain'.

I did specify (as you did) the following for Learner:

                path='./checkpoints',
                model_dir='pretrain',

Do I have to manualy save the model?

richarddwang commented 3 years ago

Make sure you include RunSteps which save models automatically for you https://github.com/richarddwang/electra_pytorch/blob/8f6ac2c7efc246a4f6275f82d8417e88d76de046/pretrain.py#L388-L397
Make sure c.steps==100
comment out RunSteps and rerun to see if there is any error, b/c sometime RunSteps intercepts the error but there is something went wrong.

PhilipMay commented 3 years ago

That works. Thanks. Closing this again...