search

richardforth / apache2buddy

apache2buddy
Apache License 2.0
384 stars 72 forks source link

Support new debian stable #374

Closed gremirarunico closed 3 years ago

gremirarunico commented 3 years ago

Giving sudo perl apache2buddy on a debian 11 we get


apache2buddy.pl report for HIDDEN (x.x.x.x)
#################################################
[ OK ] This script is being run as root.
[ OK ] The utility 'pmap' exists and is available for use: /usr/bin/pmap
[ OK ] The utility 'netstat' exists and is available for use: /usr/bin/netstat
[ OK ] 'php' exists and is available for use: /usr/bin/php
[ OK ] The utility 'apachectl' exists and is available for use: /usr/sbin/apachectl
[ OK ] The port (port 80) is a valid port.
[ -- ] We are attempting to discover the operating system type and version number ...
[ !! ] Unable to locate the 'python' binary.
[ OK ] The 'python3' binary exists and is available for use: /usr/bin/python3
[ -- ] Distro: Debian GNU/Linux
[ -- ] Version: 11
[ -- ] Codename: bullseye
[ !! ] This distro is not supported by apache2buddy.pl.
[ @@ ] Supported Distro's: 'Ubuntu', 'ubuntu', 'Debian', 'debian', 'Red Hat Enterprise Linux', 'Red Hat Enterprise Linux Server', 'redhat', 'CentOS Linux', 'CentOS', 'centos', 'Scientific Linux', 'SUSE Linux Enterprise Server', 'SuSE'. To run anyway (at your own risk), try -O or --skip-os-version-check.```

With the parameter `-O` everything works fine, so I think it should be added the new version to supported distros.
richardforth commented 3 years ago

Hi @gremirarunico,

I don't get a lot of time these days to spend on apache2buddy however if youre able to test it for me you need to add '11' to the list on line 424:

https://github.com/richardforth/apache2buddy/blob/605712301230b2787584ad58354e1f9bdbadc7da/apache2buddy.pl#L424

At least if you hack it to work for now, or if youre able to test and make the change without it breaking anything else, as its largely untested, can you make a pull request to the staging branch with the following changes:

  1. Add "11" to the list of supported debian versions to line 424
  2. Update the changelog and take credit :)
  3. sha256sum of apache2buddy.pl
  4. md5sum of apache2buddy.pl

Commit all 4 files

If you do that and youre happy with it, I'll merge it from staging.

richardforth commented 3 years ago

If you do spot any wierdness on Debian 11 and can fix those issues to, that would be awesome.

The main reason for limiting the support is to avoid odd breakages

richardforth commented 3 years ago

good news is that someone has added a merge request to fix this #378 but I haven't got around to testing it yet.

richardforth commented 3 years ago

378 has been merged, I also added a Vagrantfile for debian11 to pull from staging branch to test, no bugs found on stock builds running php7.4.

Thank you