search

richardforth / apache2buddy

apache2buddy
Apache License 2.0
386 stars 72 forks source link

feat: Add SLES12 compatibility #380

Closed ecazamir closed 2 years ago

ecazamir commented 2 years ago

Here's the code needed to make this script run fine on Suse Linux Enterprise Server v. 12.

Tested on a SLES12 machine.

Please add this to the main code line, if you plan to better support SuSE servers.

richardforth commented 2 years ago

Many thanks for this.

It looks great I am away for a few days but will get this tested and merged next week.

Kind regards Richard

On Wed, 3 Nov 2021, 19:03 ecazamir, @.***> wrote:

Here's the code needed to make this script run fine on Suse Linux Enterprise Server v. 12.

Tested on a SLES12 machine.

Please add this to the main code line, if you plan to better support SuSE servers.

You can view, comment on, or merge this pull request online at:

https://github.com/richardforth/apache2buddy/pull/380 Commit Summary

File Changes

(4 files https://github.com/richardforth/apache2buddy/pull/380/files)

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/richardforth/apache2buddy/pull/380, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABNFIV7GHEBLBSWRK7BIEY3UKGBRZANCNFSM5HJWB7UQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

richardforth commented 2 years ago

Merged into Staging I need to create a vagrantfile to test SLES12 if available

ecazamir commented 2 years ago

Thanks Richard!

richardforth commented 2 years ago

I seem to have hit a roadblock with this, SLES12 isnt free, and I'n running into issues feeling my way around a new vagrant installed SLES12, as zypper is giving me the following errors:

sles12sp1:~ # zypper install httpd
Warning: No repositories defined. Operating only with the installed resolvables. Nothing can be installed.
sles12sp1:~ # zypper install apache2
Warning: No repositories defined. Operating only with the installed resolvables. Nothing can be installed.

There isnt any way for me to test this, which also means there isnt any way for me to support it going forward, the alternative is that I merge this but not support SLE12, in other words, you'd be then responsible for making ay future change to making SLES compatible modifications in the future. which i'd rather not.

Can you get me a working Vagrant file for SLES12 that doesnt require a paid for subscription to get anything installed?

I was using this vagrant box https://app.vagrantup.com/wvera/boxes/sles12sp1

You can take inspiration from the Debian 11 one to see what packages i installed and how I pulled apache2buddy from staging with curl and perl here:

https://github.com/richardforth/apache2buddy/tree/staging/vagrantfiles_testing/Debian11

Kind Regards Richard