search

richardgirges / express-fileupload

Simple express file upload middleware that wraps around busboy
MIT License
1.52k stars 261 forks source link

Fix #239 #240

Closed AmazingMech2418 closed 4 years ago

AmazingMech2418 commented 4 years ago

Fixes #239

This simply replaces a single array of invalid keys that is manually set with two separate ones for the Object and Array prototypes in order to block all potentially harmful keys from being set. Since all objects inherit from the Object prototype, the array for the Object prototype is not conditional based on the type of the current object with the property being set.

richardgirges commented 4 years ago

This is amazing. Thanks so much for pushing a fix in addition to reporting the issue @AmazingMech2418 !! I'm cutting a release with this update ASAP.

AmazingMech2418 commented 4 years ago

Thank you!