search

richardgirges / express-fileupload

Simple express file upload middleware that wraps around busboy
MIT License
1.52k stars 261 forks source link

Remove empty files #241

Closed nusu closed 4 years ago

nusu commented 4 years ago

Follow up PR for #233

233 seemed to exclude empty files from req.files but for temporary files, it still creates a writestream right after busboy triggers the .on("file") method, I did some research in hopes to find a flag for fs.createWriteStream to actually check and remove if the file is empty on the end but there's no such a thing.

And we are not able to not create a stream while we can't get the size info until the end, so the best thing we can do is follow the condition we have on file.on('end') and cleanup if temporaryFiles is enabled.

nusu commented 4 years ago

@richardgirges can we merge this?

richardgirges commented 4 years ago

Looks good! Thanks for the PR. Merging now.