richardgirges / express-fileupload

Simple express file upload middleware that wraps around busboy
MIT License
1.52k stars 261 forks source link

UnhandledPromiseRejectionWarning: Error: ENOSPC: #256

Closed PawelSuwinski closed 3 years ago

PawelSuwinski commented 3 years ago

Hi

I am not sure if I am using it right (?), but just simple upload form and case of not enough space on disk gives UnhandledPromiseRejectionWarning:

// app.js
app.use(fileUpload({ useTempFiles: true }));
app.use((err, req, res, next) => res.status(500).send(err.message));

(node:11775) UnhandledPromiseRejectionWarning: Error: ENOSPC: no space left on device, write (node:11775) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag --unhandled-rejections=strict (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 2) (node:11775) PromiseRejectionHandledWarning: Promise rejection was handled asynchronously (rejection id: 2)

At first glance it seams that Promise.all(req[waitFlushProperty]).then(...).catch(...) (lib/processMultipart.js) it is not enough to catch writeStream errors (?), but I am just at the begin of figuring it out.

Any hints?

node: v12.19.0

+-- express@4.17.1
(...)
+-- express-fileupload@1.2.0
| `-- busboy@0.3.1
|   `-- dicer@0.3.0
|     `-- streamsearch@0.1.2

-- regards Paweł Suwiński