search

richardgirges / express-fileupload

Simple express file upload middleware that wraps around busboy
MIT License
1.52k stars 261 forks source link

Save temp file with file extension #273

Open toksdotdev opened 3 years ago

toksdotdev commented 3 years ago

I'm proposing that we save the temp file with the file extension, considering that in some cases, one might have a logic that depends on the file extension.

Currently, when a temp file is created, it strips out the file extension as shown here

Since we have the filename, we should be able to inject it into the getTempFilename(...).

I'll be very much open to creating a PR if you deem fit.

RomanBurunkov commented 3 years ago

Hi,

But the file object has a name property and in case you need an extension it is possible to get it from the original file name.

picturedots commented 1 year ago

I posted a workaround in stack overflow that

  1. gets the extension from the file object's "name"
  2. renames the temporary file to use the extension

But it will still be better for this to be the default behavior if useTempFiles: true and preserveExtension: true are used together.