Stricter content-type checks - Githubissues

richardgirges / express-fileupload

Simple express file upload middleware that wraps around busboy

MIT License

1.52k stars 261 forks source link

Stricter content-type checks #279

Closed SashaSirotkin closed 2 years ago

SashaSirotkin commented 3 years ago

Context

Enforces stricter rules on the content type. It will no longer trigger the middleware on improperly formatted requests.

Screen Shot 2021-07-15 at 6 25 28 PM

Changes

This would be a breaking change. Fixed the regex and made it more precise. The first commit is a more minimal fix.
Added tests via jest. If you prefer not to have jest as part of this PR, it can be removed and it can be the naked regex fix.
Slight tweak to the prettierrc file. If you prefer not to have jest as part of this PR, it can be removed and it can be the naked regex fix.
The lockfile was updated with node version 12.13.1.

richardgirges commented 3 years ago

Hey Sasha, thanks for the PR! I'd rather eliminate Jest in this PR, and migrate all test suites to Jest in a separate PR.

There are also some conflicts that need to be resolved.

Seems good to me otherwise

richardgirges commented 2 years ago

Following up @SashaSirotkin. Closing PR for now, please re-submit after conflicts and jest issue is resolved.