Open andrecp opened 2 years ago
It looks like the headers being sent is a bug. I'm not sure what's going on with the CORS issue though, curious if the headers being sent by express-fileupload is creating a CORS issue as a red herring. Would you be able to provide a simple app with a repro?
Hi,
Issue with headers were already sent fixed in version 1.4.2 by PR #238. In the case described above, middleware won't call next and route handler will not be invoked.
Hey folks,
I was playing with express-fileupload today and hit what I think is a bug.
With the above, if my upload view is over the limit (50MB), it should return a 413, however, I believe because it isn't setting the CORS headers correctly it doesn't return 413, instead the client side gets a CORS error.
This is my view
If I register my own
limitHandler
it then works correctly and the cors headers get setAnother interesting thing is that with my
limitHandler
I need to check if the headers were already sent, otherwise my app crashesThank you