in version 1.4.0 file names are corrupted

richardgirges / express-fileupload

Simple express file upload middleware that wraps around busboy

MIT License

1.52k stars 259 forks source link

in version 1.4.0 file names are corrupted #334

Closed vzhuk0fibery closed 1 year ago

vzhuk0fibery commented 1 year ago

steps to reproduce

have express version 4.18.1 and express-fileupload version 1.4.0 upload
create a screen shot using MacOs standard hot keys and name file "русское название файла" in finder
upload this file to the server
observe that file name has parsed as Ñ_Ñ_Ñ_Ñ_ÐºÐ¾Ðµ Ð½Ð°Ð·Ð²Ð°Ð½Ð¸Ðµ Ñ_Ð°Ð¸Ì_Ð»Ð°
but in version 1.3.1 everything was fine.

ghost commented 1 year ago

Is not a problem from fileupload itself, the error come from a node_module package busboy. To solve it add the param defParamCharset: 'utf-8' in the fileUpload creation options like

fileUpload({
    useTempFiles: true,
    tempFileDir: path.resolve(tempFolder),
    defParamCharset: 'utf-8'
})

vzhuk0fibery commented 1 year ago

I see, so I've to specify charset then. Will try to adopt it. Thanks @RaulAlcaraz