search

richardgirges / express-fileupload

Simple express file upload middleware that wraps around busboy
MIT License
1.52k stars 259 forks source link

chore: replace busboy with @fastify/busboy #361

Open rtritto opened 8 months ago

rtritto commented 8 months ago

@fastify/busboy is a better version of busboy for performance, maintenance and some solved critical bug.

Related: https://github.com/fastify/busboy/issues/68

coveralls commented 8 months ago

Coverage Status

coverage: 94.785%. remained the same when pulling 5d07c5c4cd43aeb531ca103f3a734debffed0c52 on rtritto:replace-fastify into fcb6952cfcdb7c5683a8910fe11aeb98eafc02d7 on richardgirges:master.

rtritto commented 8 months ago

@fastify/busboy forked branch isn't currently alligned with busboy branch: https://github.com/fastify/busboy/issues/78. I think we should wait to merge this.

rtritto commented 1 month ago

@RomanBurunkov @RobinTail any update to merge this PR?

RobinTail commented 1 month ago

It may appear that may, but I'm not the one who decides for this repo, @rtritto :)

You also said

I think we should wait to merge this.

So, should we? Please let the maintainer know.

rtritto commented 1 month ago

It's active and maintained by team of undici

RobinTail commented 1 month ago

@RomanBurunkov || @richardgirges , please take a look on this.

RomanBurunkov commented 1 month ago

Hi @rtritto , do not see any reasons to switch from original busboy to the fork.

Could you please provide some additional details, use cases, etc.

rtritto commented 1 month ago

@fastify/busboy advantages:

Sources: