Issue 374: Allow an option to choose the hashing algorithm

richardgirges / express-fileupload

Simple express file upload middleware that wraps around busboy

MIT License

1.52k stars 259 forks source link

Issue 374: Allow an option to choose the hashing algorithm #375

Closed Kpovoc closed 3 days ago

Kpovoc commented 3 weeks ago

hashAlgorithm key added to DEFAULT_OPTIONS
hashAlgorithm key can be overriden by value given in options argument
buildOptions function will ensure a default a hashAlgorithm exists, and throw an error if the provided option is not supported by the system.
- throws early error during app setup, rather than waiting until an upload is attempted
memHandler and tempFileHandler use the hashAlgorithm option now
Updated tests for buildOptions function in utilities.spec.js

ref: https://github.com/richardgirges/express-fileupload/issues/374

coveralls commented 3 weeks ago

coverage: 94.509% (+0.08%) from 94.428% when pulling a230423d7f6206a85ab897dedab94d4fa58ba73a on Kpovoc:master into 3325e62545af79310a54184c495f29aa49390ce2 on richardgirges:master.

coveralls commented 2 weeks ago

coverage: 94.477% (+0.05%) from 94.428% when pulling 73496500ac6ef8dcf3772c0304a318ac11310727 on Kpovoc:master into 3325e62545af79310a54184c495f29aa49390ce2 on richardgirges:master.

barucoh commented 2 weeks ago

Any chance to get this merged and released soon 🙏🏼 ?

barucoh commented 6 days ago

@RomanBurunkov @Kpovoc Gentle ping 👀

Kpovoc commented 5 days ago

@barucoh Yeah, I poked him on the linked issue. Waiting on either a merge of feedback for further changes.

RomanBurunkov commented 3 days ago

Sorry for delays lads...lot of work and also two small kids ;)