search

richardgv / skippy-xd

A full-screen Exposé-style standalone task switcher for X11.
GNU General Public License v2.0
341 stars 78 forks source link

DGifCloseFile signature changed: fixes build against giflib 5.1.0 #44

Closed devsnd closed 10 years ago

devsnd commented 10 years ago

I just tried to build skippy-xd on arch linux, but it failed (even though it did work 2 days ago).

I'm using this package build in the user repository: https://aur.archlinux.org/packages/skippy-xd-git/

I'm not sure about the versioning of libgif, but this patch is necessary for skippy-xd to compile and work at least on arch.

Here's the line in the giflib header: http://sourceforge.net/p/giflib/code/ci/master/tree/lib/gif_lib.h#l183

richardgv commented 10 years ago

Thanks for the patch, devsnd! And sorry for not replying in 3 days.

The API breakage is in giflib-5.1.0, not in giflib-5.0.x, so unfortunately we need to introduce another macro to deal with this... Could you please test if 998e0e7 fixes the issue?

devsnd commented 10 years ago

Hi Richard,

I just tried it out and it works fine. Thanks!

richardgv commented 10 years ago

Great, thanks for testing! :-)