search

richardhj / contao-ajax_reload_element

AjaxReloadElement for Contao Open Source CMS
GNU Lesser General Public License v3.0
14 stars 5 forks source link

Do not use m12 on checkboxes #17

Closed fritzmg closed 4 years ago

fritzmg commented 4 years ago

The m12 class only needs to be used on checkboxes, if they are floating in the same row as a text or select input field for example. When a single checkbox only floats by itself or together with another checkbox, the m12 class is not necessary.

Note: I think it's best though to add the functionality to its own fieldset, especially in tl_content and tl_module, since there is a subpalette present. If another extension appends to the same fieldset, the back end layout will get weird, when the subpalette is loaded. Alternatively, w50 could be removed from the checkboxes as well, may be. (I did not include either change in this PR though.)

richardhj commented 4 years ago

Good note on the fieldset. We also need to add 'exclude'=>true on the fields. But I would consider this as a breaking change. wdyt?

fritzmg commented 4 years ago

But I would consider this as a breaking change. wdyt?

imho no :)