richardios275 / fe2io-python

FE2.IO Roblox Music Player recreated with Python
MIT License
0 stars 1 forks source link

Some maps that are unmarked m4a (notably True Failure) won't play music #1

Open some100 opened 1 month ago

some100 commented 1 month ago

For most maps it works perfectly fine. However, some maps, like True Failure, the program breaks (stops playing any more music) upon trying to play those maps. This forces a restart of the program whenever, for example, I play a multiplayer server, and True Failure happens to be loaded. What gives? image

Well as the README says, m4a files are unsupported and (are usually) auto converted into mp3 before being played. However, it seems like audio downloaded from Jukehost with this program tend to not have a file extension. This means that the program can't really tell if it's an m4a or mp3 file (because it only has the file extension to go off of). In the image there are 2 audios downloaded from Jukehost, and 1 downloaded from GitHub using this program. Notice how they don't have any file extensions. image

As a result, the program interprets the audio file as being mp3, and therefore playable. Even if it isn't. This results in it breaking.

some100 commented 1 month ago

2 fixes this btw