A failed build should cost one beer.

richardkmichael / buy-my-beer

Make broken builds a thing of the past! Broken builds cost you a beer!

1 stars 0 forks source link

A failed build should cost one beer. #2

Closed richardkmichael closed 13 years ago

richardkmichael commented 13 years ago

When a failed build is created, one beer is marked owing against the committer of the failed build.

This should be done with hooks in the Build model -> User ; not in the BuildController.

Add testing: controller, but also against the API/running service (how?)

richardkmichael commented 13 years ago

API specific tests not written, as this was done with a Build model callback it should "just work".

Implemented in these two commits:

(I should have moved some of the hunks from the commit to the second commit)

SHA: 7262a329cc28b9fc658a33ab8744c716a60b68c1 Move remaining TODOs to issues. SHA: 51d5ebf4ddbac6ea6e0f8651133ef4a285753606 Add beers attribute to the User model.

Next time, I'll try a PR and merge using GitHub.