search

richardlehane / siegfried

signature-based file format identification
http://www.itforarchivists.com/siegfried
Apache License 2.0
224 stars 30 forks source link

Implementation of basic Wikidata identifier #138

Closed ross-spencer closed 3 years ago

ross-spencer commented 4 years ago

Implements an identifier based on the information recorded about file formats in Wikidata. (At least, a good first iteration of an identifier).

NB. will drop you an email later tomorrow!

ross-spencer commented 3 years ago

Awesome thanks @richardlehane and yeah, I share the same thoughts about the sourceinline flag. It will be great to commit to removing that in the next release. I feel too based on the previous discussions we're on the right path for the default view there so I think that will be possible.

RE: Arc work - the code here lays the foundation for https://github.com/richardlehane/siegfried/pull/141. I cherry-picked most of 141 for Wikidata as it just made sense to me that it was all there and easy to incorporate. That being said to provide arc selector capability now 141 does need a quick rebase which I was hoping to do against develop so I can perhaps do that later today? And then folks with the new version can select their archives! Or we can hold off. I think it's just an hour or so needed to bring 141 in-line with a develop branch which incorporates this one.

richardlehane commented 3 years ago

Merged! If you could prep #141 for merging too that'd be great