search

richardlehane / siegfried

signature-based file format identification
http://www.itforarchivists.com/siegfried
Apache License 2.0
217 stars 30 forks source link

Roy expects quotation marks in Droid csv from Siegfried for comparison #174

Closed ostnatalie closed 2 years ago

ostnatalie commented 2 years ago

Hello, We tried to use Roy for comparing output files from Siegfried and Droid. We were comparing Droid csv output from Siegfried and csv output from using this command:

roy compare file1.csv file2.csv > comparison.csv

We got this:

“2022/01/05 09:57:39 not a valid results file, bad char 73”

(file1 is Droid csv from Siegfried, file2 is from Droid)

We have found out that it was probably caused by the “missing” quotation marks in column names in Droid csv from Siegfried.

Output from Droid Droid_output

Output from Siegfried image

When we added the quotation marks to that Siegfried output then Roy carried out the comparison.

So we are sending this in case it could be useful information, that Roy expects the quotation marks in the Droid csv output from Siegfried.

We then tried it with JSON output from Siegfried and with normal csv from Siegfried and it worked perfectly.

richardlehane commented 2 years ago

thanks for reporting this @ostnatalie - I expect this will be a general bug in how siegfried reads droid-formatted csv files it has created itself (so will impact sf -replay functionality too). I'll try to fix for the next release