richardlehane / siegfried

signature-based file format identification
http://www.itforarchivists.com/siegfried
Apache License 2.0
217 stars 30 forks source link

Invalid JSON for fmt/1472 #186

Closed Sembiance closed 2 years ago

Sembiance commented 2 years ago

The file inside the attached XXX_INT.MSA.zip matches against: https://www.nationalarchives.gov.uk/PRONOM/fmt/1472

The PRONOM data has a 'tab' character at the beginning of the MIME field, which causes JSON parsers to choke on siegfried's output.

I don't know how to submit a bug to the PRONOM folks.

richardlehane commented 2 years ago

thanks for reporting this Robert, I'll add a test in to guard against invalid JSON values in the mime field

Sembiance commented 2 years ago

Awesome, sounds good. PRONOM will also be fixing this in their next release: https://github.com/nationalarchives/pronom/issues/1

Thanks for making siegfried!!

richardlehane commented 2 years ago

fixed in v1.9.3