richardlehane / siegfried

signature-based file format identification
http://www.itforarchivists.com/siegfried
Apache License 2.0
214 stars 30 forks source link

Docker image release #200

Closed luis100 closed 1 year ago

luis100 commented 1 year ago

It would be convinient for us to have a Siegfried available as a Docker container. To that point, we have done a minimal project that allows to build a Docker image with Siegfried: https://github.com/keeps/siegfried-docker

And we push this to Docker Hub: https://hub.docker.com/repository/docker/keeps/siegfried

But this would be better managed by an a GitHub action called by a release dispatch trigger in this repository, just as we do here: https://github.com/keeps/dbptk-ui/blob/master/.github/workflows/release.yml#L64-L68

We suggest you to incorporate our siegfried-docker project into the richardlehane group and set up this inter-project Github workflow, or if you don't mind, call our (keeps) siegfried-docker project from your own Siegfried Github actions release workflow, and we can do the rest.

richardlehane commented 1 year ago

Hi Luis - I'm happy to add this to the release.yaml github action. Suggest may be simplest just to keep the repository with you. Could you do a PR with the changes you need? If necessary to add a secret token to the repository I can do that, perhaps just email it to me?

luis100 commented 1 year ago

@hmiguim please create PR and send secret via email

richardlehane commented 1 year ago

closed with v1.9.5