richardlehane / siegfried

signature-based file format identification
http://www.itforarchivists.com/siegfried
Apache License 2.0
214 stars 30 forks source link

fmt/1741: signatures with offsets that commence with ranges of wildcards #203

Closed richardlehane closed 1 year ago

richardlehane commented 1 year ago

Signatures for this new format have min/max offsets 32768/70468 as well as a starting range {0-16}.

The PRONOM parser is incorrectly reading this as a min/max offset of 0/16.

Probably should resolve to min/max offsets of 32768/103252 [not 70484 as confusingly the PRONOM max offset value is relative to the offset value!]

Dclipsham commented 1 year ago

Ooh that's subtle. Needs fixing upstream for sure

richardlehane commented 1 year ago

sorry I meant siegfried's PRONOM parser!! The DROID report for this one looks OK

Dclipsham commented 1 year ago

I meant think the sig right now just needs tweaking. Without an anchor before the {0-16} its logically just saying Min offset 32768 max offset 70500 so no reason to combine signature constructs to achieve that I think

richardlehane commented 1 year ago

true :)