search

richardmiller-zz / BehatSpec

Extensions to integrate Behat and PhpSpec
MIT License
51 stars 6 forks source link

Extensions are not installed in v0.4.0 #23

Closed ek9 closed 7 years ago

ek9 commented 7 years ago

When installing 0.4.*, no extensions are installed.

$ composer require rmiller/behat-spec 0.4.*
    - Installing rmiller/caser (0.1.0) Loading from cache
    - ...
    - some more deps installed here
    - ...
    - Installing behat/behat (v3.3.0) Loading from cache
    - Installing phpspec/phpspec (2.5.5) Loading from cache
    - Installing rmiller/behat-spec (0.4.1) Loading from cache
Writing lock file
Generating autoload files

I believe either the changes from v0.3.2 should be also merged to v0.4. Installing v0.3.2 pulls up all the required extensions correctly, while using v0.4 does not install any extensions. However, the 0.3.2 has <0.4 version constraints, so that would need to be adjusted accordingly.

I am not sure what is the intention of v0.4 series at this moment. Are extensions safe to update to v0.4 too (for phpspec2)?

Before I do a PR:

Which branch will we use for v0.4 series? Do we continue with phpspec2-support or will you branch out from v0.4.0 tag with a new branch?

ek9 commented 7 years ago

Actually I just realised that it's already subtreesplit for v0.4 series, thus we only need to fix the namespaces (same issue as #18 )