richardmiller-zz / BehatSpec

Extensions to integrate Behat and PhpSpec
MIT License
51 stars 6 forks source link

Extension namespace fix to be PSR-4 compatible after monorepo merge #25

Closed ek9 closed 7 years ago

ek9 commented 7 years ago

This is a big PR with the following changes:

This is related to and fixes #18 #23

I have made sure all the tests pass in all extensions where the tests were setup. There is still ExemplifyExtension tests failing, but it's same failures that were there before this PR (I've made a sparate issue to track it)

ek9 commented 7 years ago

I belive src/Extension directory is setup as part of subtreesplit. I would suggest to get rid of that instead and use src/<EXTENSION> structure. We could then also remove the Extension sub-namespace to clean it up, however that would require further updates to subtreesplit + break compatibility with 0.4

ek9 commented 7 years ago

This would fix #25

ek9 commented 7 years ago

This would also fix #5 as I have tried running the updated version on an existing behat/phpspec heavy project which previously relied on phpspec2 and it seems to work fine with PHPSpec3 so far.

richardmiller-zz commented 7 years ago

Brilliant, thank you for this!