search

richardmiller-zz / BehatSpec

Extensions to integrate Behat and PhpSpec
MIT License
51 stars 6 forks source link

Remove composer.lock from git repository #29

Closed ek9 closed 7 years ago

ek9 commented 7 years ago

I believe the composer.lock file should not be part of this repository. The reasons being:

  1. The CI should always run against latest versions of the package. As that is what any new user installing the package will get. This will make sure that we see any kind of breaking due to version updates early and can update our version constraints in composer.json file accordingly.
  2. composer.lock is a common source of conflicts when developing / doing PRs, thus it becomes problematic as you need to rebase a lot of PRs if this file is updated.
  3. Generally it's ok to include composer.lock in projects, but as this is more of a library/tool that is fetched and used by other users, then composer.lock should not be included in the repository. (Read more @ http://stackoverflow.com/a/24247443 )
ek9 commented 7 years ago

I've just realised this is gone already. Closing.