search

richardmiller-zz / BehatSpec

Extensions to integrate Behat and PhpSpec
MIT License
51 stars 6 forks source link

ErrorExtension: Rename ErrorObserver interface to ErrorObserverInterface + Update PhpSpecExtension #36

Closed ek9 closed 7 years ago

ek9 commented 7 years ago

Fixes #34

richardmiller-zz commented 7 years ago

I'm not keen on this, I don't like the Interface suffix, this is only an issue if the implementation does not have a more specific name and it should as it will be observing for a specific error.

ek9 commented 7 years ago

Yeah I understand, my idea was to stick as close to PHP-FIG / PSR-11 standards as possible ( https://groups.google.com/forum/?fromgroups#!topic/php-fig/S-URR0_h2U0 ). However, there is no reason to force it if you don't like it, so I am closing this.