richardscarrott / jquery-ui-carousel

jQuery RS Carousel is a responsive and touch-enabled carousel written on top of jQuery and the jQuery UI Widget Factory providing a full and familiar API in less than 2.6kB minified and gzipped.
http://richardscarrott.github.io/jquery-ui-carousel/
192 stars 56 forks source link

[bug] Continuous extension breaks goToPage #15

Closed richardscarrott closed 12 years ago

richardscarrott commented 12 years ago

The _isValid method is made void by the continuous extension to ensure the next and prev buttons will continue to get to _slide. This means using goToPage({any invalid number}) will cause the carousel to act as if it's doing a continuous loop (with the fake jumps).

To fix this the continuous index correction needs to be moved from the _slide method and into the prev and next methods, the fake position jump should ideally be kept in _slide and the _isValid method left alone.