search

richardscarrott / jquery-ui-carousel

jQuery RS Carousel is a responsive and touch-enabled carousel written on top of jQuery and the jQuery UI Widget Factory providing a full and familiar API in less than 2.6kB minified and gzipped.
http://richardscarrott.github.io/jquery-ui-carousel/
192 stars 56 forks source link

Disabled state causes opacity to be .35 #16

Closed itay closed 12 years ago

itay commented 12 years ago

If you have the JQuery UI CSS files (for example, jquery.ui.all.css), then _checkDisabled will cause the entire carousel to go "transparent", because that is what JQuery UI sets it too. You can override it manually, but that seems unfortunate.

richardscarrott commented 12 years ago

I've not really used jQuery UIs CSS / theme roller to a great extent but that seems like a bit to much of an assumption to say all widgets will want to be translucent when disabled but I guess there's no harm in overriding it.

Saying that I've been hesitant towards integrating the carousel with theme roller as I've found a carousel's style is often dictated by it's content and any other aesthetic flourishes tend to be relatively bespoke so I don't think I want to add that declaration to the core CSS just yet.

itay commented 12 years ago

My problem specifically came from the fact I also use the JQ-UI progress bar widget, which requires some of the CSS. Even if you don't add the opacity reset yourself, it might be worthwhile to just document that this could happen now that it is built as a JQ-UI widget.

richardscarrott commented 12 years ago

I'll make a note when I update the docs for the latest version.