richardscarrott / jquery-ui-carousel

jQuery RS Carousel is a responsive and touch-enabled carousel written on top of jQuery and the jQuery UI Widget Factory providing a full and familiar API in less than 2.6kB minified and gzipped.
http://richardscarrott.github.io/jquery-ui-carousel/
192 stars 56 forks source link

touch #41

Closed jaxuk closed 12 years ago

jaxuk commented 12 years ago

I can't seem to get any of the touch functionality working on Android, is there a demo somewhere?

jaxuk commented 12 years ago

found it http://www.richardscarrott.co.uk/assets/javascript/jquery/ui-carousel-touch/demo.html

richardscarrott commented 12 years ago

I'd bear in mind that's a really old version of the carousel, it was the first iteration of the touch extension. I don't recall whether the touch extension works on Android in all honesty, it was mainly written to support mobile Safari on iOS.

I'm making some updates to the core carousel (to support variable width items) that'll require the continuous and touch extensions to be rewritten slightly so if it doesn't currently work on Android it likely will shortly.

jaxuk commented 12 years ago

Ah ok! I tested the link above on my Android device and it works very well.

I've tried to get the touch extension working in the latest version downloaded from here but without much success. Any ideas?

richardscarrott commented 12 years ago

Unfortunately I don't have an android device at hand to test this on so it's hard to say what the issue might be.

There are some significant differences between the latest touch extension and the one used in that link, namely the use of jquery.event.drag instead of jQuery UIs draggable interaction widget (combined with a hacky touch fix) so it might be a case that the jquery.event.drag doesn't work in Android (unfortunately the project appears to be dead).

I plan to attend to these issues, which might mean using a different draggable lib, once I push the next version out but I can't say when that might be.

jaxuk commented 12 years ago

OK thanks for the info Richard.

I'll have another look at it, but I'll probably wait until your next version.

Thanks for a great plugin!

On 21 April 2012 10:33, Richard Scarrott < reply@reply.github.com

wrote:

Unfortunately I don't have an android device at hand to test this on so it's hard to say what the issue might be.

There are some significant differences between the latest touch extension and the one used in that link, namely the use of jquery.event.drag instead of jQuery UIs draggable interaction widget (combined with a hacky touch fix) so it might be a case that the jquery.drag.event doesn't work in Android and I've also heard it has issues with jQuery 1.7+ (unfortunately the project appears to be dead ).

I plan to attend to these issues, which might mean using a different draggable lib, once I push the next version out but I can't say when that might be.


Reply to this email directly or view it on GitHub:

https://github.com/richardscarrott/jquery-ui-carousel/issues/41#issuecomment-5259296

Jacques Woolston

Yedit.co.uk - Content Management, Web Development, Graphic Design, Web Hosting, SEO and much much more.

www.yedit.co.uk

Tel: 004420 8144 2716

V-Alexeev commented 12 years ago

Jacques, I believe your issues with the touch extension might be fixed in my fork of this plugin: https://github.com/V-Alexeev/jquery-ui-carousel (the fix is really tiny btw)

We're heavily using the touch extension with Android devices and it works as it should.

(I created pull request #36 long ago, but Richard has not accepted it yet)

richardscarrott commented 12 years ago

Yeah I've not had a chance to test your pull request but from looking over your change you're fixing an issue in the carousel code whereas the issue is actually with the drag lib so whilst it may fix it for now, it's not something I want to pull in to the main branch; I'd rather find and fix the root of the problem than mask it.

But of course I've not actually fixed the main branch yet so by all means your fork is a possible solution until I find the time to make the next release.

richardscarrott commented 11 years ago

I've made an update to the latest touch extension which now uses a custom version of jquery.event.drag.js forked from a slightly newer version of the original jquery.event.drag.js. I still don't have an android device to test but it's probably worth a shot now.