search

richardscarrott / jquery-ui-carousel

jQuery RS Carousel is a responsive and touch-enabled carousel written on top of jQuery and the jQuery UI Widget Factory providing a full and familiar API in less than 2.6kB minified and gzipped.
http://richardscarrott.github.io/jquery-ui-carousel/
192 stars 56 forks source link

CSS is inlined #5

Closed LinusU closed 13 years ago

LinusU commented 13 years ago

Shouldn't the css be in a separate file called jquery.ui.carousel.css? I might have overlooked something and there might be a valid reason for keeping the css inlined but it seems more clean to have it in a separate file.

richardscarrott commented 13 years ago

Yes, it should. It's simply a case of not having the time to move it out into it's own file but yes you're correct. I would advise anybody to move it into a separate file.

When I eventually finish everything and release v1.0 then I'll make sure everything is properly packaged up and likely separate functional styles and aesthetic styles for easy customisation.

LinusU commented 13 years ago

Ok, thanks for the quick response! I guess that the goal is to be integrated into jQuery UI, or are you planning on releasing this as a stand alone plugin?

richardscarrott commented 13 years ago

When I get some spare time I'll tidy everything up and release this as version 1.0 and see what happens but it'd be nice if it was considered for jQuery UI but I believe they're busy re-factoring a lot of their current widgets and working on a grid et. al. so I don't see it being all that likely, at least not until 1.9 is out the door.

kflorence commented 13 years ago

@richardscarrott I'm in the same boat with several of my plugins. I think it's best to not use the jQuery UI namespace until it becomes part of the official jQuery UI library. I talked with some of the UI staff about this, they recommend using your own namespace in the widget definition and releasing the code as a jQuery plugin (jquery-carousel).

richardscarrott commented 13 years ago

Yeah I wish I had used my own namespace in the first place as I only became aware that it's frowned upon to use the ui namespace after I had set it up on github. I've every intention of moving it out to my own namespace but it's just a case of finding the time!

kflorence commented 13 years ago

@richardscarrott Yeah, I did the same thing, seems like a common misconception. The jQuery UI team is pretty forgiving, though they do appreciate it when things are re-namespaced.