search

richardscarrott / jquery-ui-carousel

jQuery RS Carousel is a responsive and touch-enabled carousel written on top of jQuery and the jQuery UI Widget Factory providing a full and familiar API in less than 2.6kB minified and gzipped.
http://richardscarrott.github.io/jquery-ui-carousel/
192 stars 56 forks source link

denote dependencies for Rails 3.1 asset pipeline and fix a label name mismatch in demo.html #6

Closed zonque closed 12 years ago

richardscarrott commented 13 years ago

Is that dependency syntax specific to Rails or is it a recognised standard as I don't want to add it in if it has no meaning outside of Rails.

Either way I've made some significant changes to the carousel including changing the file names and tabs to spaces so merging in your pull request is probably going to be more hassle than re-adding the dependencies to the new code.

Also if you're interested in seeing the the update you can see it working here: http://www.richardscarrott.co.uk/assets/javascript/jquery/ui-carousel/demo/

zonque commented 13 years ago

The syntax is specific to Sprockets (https://github.com/sstephenson/sprockets), which is used by Rails. I don't known whether any other Web framework uses it. However, as they are marked as comments, there should be zero risk of causing problems to other users, and it actually solved the file loading ordering trouble I had.

Regarding the merge: my three lines of changes have been trivial enough to just re-add it to the new code base. Just do that if you want, I won't insist on the commit ownership in that case :)

richardscarrott commented 12 years ago

Because this is only relevant to sprocket users I'm going to avoid adding these to the latest code.

Also, looking at your dependencies, it might be worth noting that the carousel doesn't actually depend on jQuery UI. It uses jquery.ui.widget.js but the this can run independently from core etc.

Cheers, Rich