search

richardscarrott / jquery-ui-carousel

jQuery RS Carousel is a responsive and touch-enabled carousel written on top of jQuery and the jQuery UI Widget Factory providing a full and familiar API in less than 2.6kB minified and gzipped.
http://richardscarrott.github.io/jquery-ui-carousel/
192 stars 56 forks source link

Compatibility with jQuery 1.9.1 #60

Closed rodeoramsey closed 11 years ago

rodeoramsey commented 11 years ago

In my testing, it seems that the carousel is not compatible with the latest version of jQuery, (1.9.1). Is this a known issue and/or are there any plans to fix? I am not a programmer so forgive me if I'm missing something. Thanks.

richardscarrott commented 11 years ago

Just tested it out with 1.9.1 and it appears to be working fine for me, could you provide any errors you're seeing?

rodeoramsey commented 11 years ago

Hi Richard,

You can see in my test file at http://bit.ly/ZBVoxe -- It's currently using Google hosted jQuery version 1.8.3. If I change the script link to version 1.9.1 and reload the page, the carousel is broken. Thoughts?

Thanks, Ramsey info@cowgirlexpressions.com

On 4/18/2013 2:53 PM, Richard Scarrott wrote:

Just tested it out with 1.9.1 and it appears to be working fine for me, could you provide any errors you're seeing?

— Reply to this email directly or view it on GitHub https://github.com/richardscarrott/jquery-ui-carousel/issues/60#issuecomment-16596986.

richardscarrott commented 11 years ago

Ah I see the problem, you're not using this carousel you're using an older plugin from a while back - https://github.com/richardscarrott/jquery-carousel

That makes use of $.browser which was deprecated in 1.9.* so it'll likely be throwing an exception on that. Seeing that you're using the multiple row feature which isn't supported in this newer carousel I'd recommend giving the migrate plugin a go which will re-introduce anything that was removed from the jQuery API with 1.9 including $.browser. Alternatively you could just remove the reference to $.browser in the code and not worry about the code fork for IE.