_slide is overriding carouselafter.originalEvent when translate3d is set

[ghost]

STEPS TO REPLICATE:

• Instantiate a carousel to include translate3d, and using the default slide value for option.fx
• Attach an event handler to carouselafter:

$(':rs-carousel').on('carouselafter', myHandler);

• Click the "next page" control

EXPECTED RESULTS:

• myHandler receives a jQuery carouselafter event with an originalEvent having a type of carousel:next

ACTUAL RESULTS:

• myHandler receives a jQuery carouselafter event with an originalEvent having a type of transitionend

DISCUSSION: This appears to be related to this code snippet (Line 542):

                    // Here e is the original 'carousel:next' event
                    .on(transitionEndEvent.join(' '), function (e) {
                        self.element.removeClass(fullName + '-transition');
                        if (!silent) {
                            // Now e is the incoming 'transitionend' event, instead of the original event
                            self._trigger('after', e, self._getEventData());
                        }
                    })

It appears that you are overriding the original event object e by using it as the parameter for your anonymous function. Removing the e parameter, or renaming it to ev, fixes the issue.

However, I'm unsure of your intent for this block. Are you intending to propagate the transitionend event, or override it with the carousel:next as we expect?

[richardscarrott]

Good catch and thanks for the detailed report. Your expected outcome is as I had intended it so it appears I've accidentally defined e in the the transitionend callback's scope. If you want to send a pull request with the e removed from that callback then I'll merge it in otherwise I'll look to make the change as soon as I get a chance.