richardschneider / net-mdns

Simple multicast DNS
MIT License
227 stars 79 forks source link

MulticastService with multiple NICs #40

Closed eshvatskyi closed 5 years ago

eshvatskyi commented 5 years ago

@richardschneider I've tried to do not create breaking changes as much as possible. But looks like without multi senders, all messages go to "default" nic with system defined route. Tried a lot of different solutions. Also, receiver added to the multicast group by local address defined, this also allows receiving messages from all interfaces, because of even using of IPAddress.ANY when joining to the multicast group return messages only from "default" NIC.

PS. By default NIC, I mean, NIC that has lower Number in NICs table :)

eshvatskyi commented 5 years ago

@richardschneider idk how to fix this, all commit's looks fine.

michaelosthege commented 5 years ago

This PR looks interesting, particularly because it looks like a more generalized solution to the problem I tried to solve with #32

richardschneider commented 5 years ago

@michaelosthege I agree! Once this is accepted. Then we can work on you needs. I'm thinking all we need is white list of nics (CIDRs) to use.

eshvatskyi commented 5 years ago

@richardschneider looks like now all commits are fine. Also added 1 fix for handling duplicated message received (MulticastLoopback)

eshvatskyi commented 5 years ago

@richardschneider 1 check is disappeared from the pipe, is something wrong?

eshvatskyi commented 5 years ago

@richardschneider Do we stack here? anything wrong or we don't want this PR at all?

cerna commented 5 years ago

Hello, would like to inquire about resolution of this problem? I need solution for service discovery and current status of master branch is broken/non-working even with additional network interfaces disabled. The changes of eshvatskyi on first glance works a lot better (but it's development branch).

richardschneider commented 5 years ago

@cerna thanks for the feedback and kicking me to do something.

BTW: Have you tried the Nuget realease?

cerna commented 5 years ago

@richardschneider Browsing Microsoft's official Nuget repository and choosing apropriate building block to build my hous.. err project was how I got here in the first place. (And I think many people do so nowadays, so having nuget for project discovery is a must.)

And I thank you for project not being dead.

richardschneider commented 5 years ago

This fixes #14