search

richardszalay / helix-publishing-pipeline

Unified publishing for Sitecore Helix solutions that extends existing Visual Studio and command line workflows
MIT License
68 stars 18 forks source link

Fix transform condition #36

Closed luuksommers closed 5 years ago

luuksommers commented 5 years ago

I think the condition is wrong, I've tried to go on without any Web.Helix.config and setting the IncludeHelixWebConfigTransformInPackage to false, but I would always get the message No transforms were supplied at packages\RichardSzalay.Helix.Publishing.WebRoot.1.4.1\build\Helix.Publishing.Plugins\MergeHelixModuleWebConfigTransforms.targets(55,5). I think this is because the $(HelixModuleWebConfigTransforms) always has a value, even though there are no files found.

richardszalay commented 5 years ago

Ah damn. I guess my fix for transforms introduced an issue for when there are no transforms. There's no test case for that.

If you just want to get your build working again, jump back to 4.0.0.

If you'd like to supply a PR, just add support in the Feature/Foundation CSPROJ so that the Web.Helix.config <Content> element has a condition Condition="'$(ExcludeHelixTransforms)' != 'true'". Then add a test for "applies default transform when no helix transforms are available"

richardszalay commented 5 years ago

(just realised this is a PR)

richardszalay commented 5 years ago

I'm going to reject this PR as the bug is unrelated to IncludeHelixWebConfigTransformInPackage. Your change would only ever apply Web.Helix.config transforms when the user wants to include the merged transform file (as well as the transformed Web.config) in the package. If you want to disable the "merge helix transforms" feature, you should set MergeHelixModuleWebConfigTransforms to false.

Having said that, the handling of a lack of transforms is indeed broken so I'm creating some tests and fixing that behaviour now.

richardszalay commented 5 years ago

@luuksommers Can you check1.4.2-beta1 and see if it resolves the issue for you? If so, I'll publish it as a full release.

luuksommers commented 5 years ago

Yes, I'll check it this weekend!

On Thu, Nov 22, 2018, 06:43 Richard Szalay <notifications@github.com wrote:

@luuksommers https://github.com/luuksommers Can you check1.4.2-beta1 and see if it resolves the issue for you? If so, I'll publish it as a full release.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/richardszalay/helix-publishing-pipeline/pull/36#issuecomment-440919292, or mute the thread https://github.com/notifications/unsubscribe-auth/ABIYH5q3F2jLzOog_Ddagy5xQDfgquBlks5uxjmWgaJpZM4YuZ3B .

richardszalay commented 5 years ago

Released as 1.4.3 (1.4.2 was published in error)