search

richardszalay / helix-publishing-pipeline

Unified publishing for Sitecore Helix solutions that extends existing Visual Studio and command line workflows
MIT License
68 stars 18 forks source link

`CollectAdditionalFilesToRemoveFromTarget` fails via `PackageReference` #54

Closed richardszalay closed 5 years ago

richardszalay commented 5 years ago

From Helixbase/#20.

It looks like the targets file is imported before the MSBuild Web targets, so CollectAdditionalFilesToRemoveFromTarget ends up being the first dependency of WebFileSystemPublishDependsOn, before the files have been copied to the temp directory. On a fresh publish, our call to CollectFilesInFolder fails because $(WPPAllFilesInSingleFolder) doesn't exist.

Solution would be to add PipelineMsdeploySpecificTransformPhase to the dependencies of CollectAdditionalFilesToRemoveFromTarget

richardszalay commented 5 years ago

Confirmed, solution works as expected. Prepping release.