richardszalay / helix-publishing-pipeline

Unified publishing for Sitecore Helix solutions that extends existing Visual Studio and command line workflows

MIT License

68 stars 18 forks source link

Run test suite against a PackageReference-based fixture #55

Closed richardszalay closed 5 years ago

richardszalay commented 5 years ago

54 has made it obvious the the target import order of `PackageReference` can cause issues to arise that aren't covered by the existing test suite.

This change would introduce:

A new 'packagereference' fixture that uses packagereference to target the in-repo version of HPP
A refactor of all tests to run against all fixtures (allowing for an SDK-project fixture in the future)

richardszalay commented 5 years ago

It turned out that actually referencing via PackageReference was complicated by both local package caching and build order, so the default fixture was instead modified so that the HPP targets were imported before the Web application targets (which also happens when PackageReference is used)

This change seems to replicate the previously seen PR issue and also uncovered 2 more, so it will probably do for the time being

richardszalay / helix-publishing-pipeline

Run test suite against a PackageReference-based fixture #55

54 has made it obvious the the target import order of PackageReference can cause issues to arise that aren't covered by the existing test suite.

54 has made it obvious the the target import order of `PackageReference` can cause issues to arise that aren't covered by the existing test suite.