search

richardtallent / vite-plugin-singlefile

Vite plugin for inlining JavaScript and CSS resources
MIT License
808 stars 53 forks source link

fix #31 #80

Closed velzie closed 1 year ago

velzie commented 1 year ago

wraps everything in a data url import

richardtallent commented 1 year ago

This is a major change with no conversation, no issue reference/explanation, etc. Issue "31" seems unrelated. I'm headed out to Burning Man and will not be able to address this PR at this time, but if you can provide more detail about why the heck we would need to use a data URL for scripts, I can take a look again when I return (after Sept. 8).

velzie commented 1 year ago

apologies, it was a temporary workaround and should have been referenced as a commit on the issue page, I'll close this and discussion can be resumed later