Closed mrahtz closed 8 years ago
Hi Matthew, Thanks very much for spotting this and the suggested fix! It would work well but for some other mistakes I noticed on revisiting the step current class... basically I hadn't dealt with the subset input parameter, which is used when splitting neuron groups across parallel processes. So inspired by your pull request I have updated the step current class and that should fix both the issue you raised and the potential problems with parallel simulations I hadn't spotted before.
Hello!
I have problems when trying to use the step current input. Modifying tutorial 2, for example, with
the simulation gives
The issue seems to be that the code in
NeuronModel_adex
is expecting an N x M matrix for input current, where N is the number of neurons and M is the number of compartments per neuron, butInputModel_i_step
only produces a 1 x M matrix:This doesn't happen in
InputModel_i_ou
because absxfun
is performed onmeanInput
, causing singleton expansion:This branch fixes the issue by just doing a
repmat
onmeanInput
insideInputModel_i_step
.Thanks! :) Matthew