search

richardtop / CalendarKit

📅 Calendar for Apple platforms in Swift
https://www.youtube.com/watch?v=cJ63-_z1qg8
MIT License
2.49k stars 334 forks source link

Added callback when canceling a viewpager's transition #282

Closed RareScrap closed 3 years ago

RareScrap commented 3 years ago

The solution to this problem. It seems to me that the library is missing a page transition cancellation callback.

richardtop commented 3 years ago

Looks good! Thanks for your pull request. I'll merge it as soon as you unmark it as "WIP".

RareScrap commented 3 years ago

Nooo! It's still WIP. I wanted to add a parameter indicating which controller the pager wanted to transit to, but couldn't :)

richardtop commented 3 years ago

No problem I believe, it's a good idea to merge it this way, it's already a usable API. Moreover, exposing the underlying controller all the way thru DayView might not be a good idea, it's enough to pass a date of the cancelled controller, since that would be similar to the CK interface. That would be a nice addition, but definitely not urgently necessary.