search

richardtop / CalendarKit

📅 Calendar for Apple platforms in Swift
https://www.youtube.com/watch?v=cJ63-_z1qg8
MIT License
2.49k stars 334 forks source link

Removed dependency on DateToolsSwift #286

Closed grosch closed 3 years ago

grosch commented 3 years ago

Not sure how to test this, but I removed the DateToolsSwift package and just used the standard methods Foundation provides. Most of the stuff that library was doing is pretty simple in the newer versions of Swift, so I think it's good to remove that dependency.

Happy to do more work on this.

grosch commented 3 years ago

Fixes issue #285

richardtop commented 3 years ago

Hi, thanks a lot for this pull request. Removing DateTools has been definitely in the consideration. Overall it looks pretty good. Could you please add the following to your pull request:

  1. Remove DateTools from the .podspec file, as to not to include this framework when installing with the CocoaPods
  2. Rewrite sample apps to not use the DateTools. Currently, your pull request doesn't compile with the sample apps (because sample apps use DateTools).
  3. To simplify the part 2 (rewrite of the apps), feel free to leave just the CustomCalendarExampleController and remove the ExampleController and the ExampleNotificationController.

Really good job and I'm looking forward to merging it as soon as those issues are fixed.

grosch commented 3 years ago

There ya go.

On Nov 14, 2020, at 12:59 PM, Richard Topchii notifications@github.com wrote:

Hi, thanks a lot for this pull request. Removing DateTools has been definitely in the consideration. Overall it looks pretty good. Could you please add the following to your pull request:

Remove DateTools from the .podspec file, as to not to include this framework when installing with the CocoaPods Rewrite sample apps to not use the DateTools. Currently, your pull request doesn't compile with the sample apps (because sample apps use DateTools). To simplify the part 2 (rewrite of the apps), feel free to leave just the CustomCalendarExampleController and remove the ExampleController and the ExampleNotificationController. Really good job and I'm looking forward to merging it as soon as those issues are fixed.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/richardtop/CalendarKit/pull/286#issuecomment-727264548, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACNEPWGZQCCE7Q6QNIG6TLSP3VU3ANCNFSM4TVNNSGA.