richardtop / CalendarKit

📅 Calendar for Apple platforms in Swift
https://www.youtube.com/watch?v=cJ63-_z1qg8
MIT License
2.49k stars 334 forks source link

Italian localization #303

Closed spiccinocchi closed 3 years ago

spiccinocchi commented 3 years ago

New Issue Checklist

Issue Description

Missing Italian localization, it's possibile to add?

richardtop commented 3 years ago

Hi Simone, it's possible. Could you please add it yourself to this folder? https://github.com/richardtop/CalendarKit/tree/master/Source/Localizations

Take a look on how the iOS calendar translates strings "12:00" and "all-day" and just add them to the Localizable.strings.

Looking forward to your pull request.

spiccinocchi commented 3 years ago

Hi, thank you for for accepting my request. With CocoaPods I can istall only version 0.14.8 but you have relase version 1.0.0, Is it correct?

richardtop commented 3 years ago

Please, share the line you have for the CalendarKit in Podfile

spiccinocchi commented 3 years ago

Hi, I solved my issue with CocoaPods and now correctly install versione 1.0.4. But I have notice that the All-Day string is still not localized.

richardtop commented 3 years ago

Could you share a screenshot of your project configuration and the screenshot of the app? This is not reproducible in Cocoapods / SPM, for me the localization is always displayed correctly.

richardtop commented 3 years ago
Screen Shot 2021-04-27 at 19 42 17 Screen Shot 2021-04-27 at 19 42 32

Simulator Screen Shot - iPhone 12 Pro - 2021-04-27 at 19 44 12

spiccinocchi commented 3 years ago

here is my project configuration and a screenshot of my app:

Schermata 2021-04-27 alle 21 59 22 Simulator Screen Shot - iPhone 12 Pro - 2021-04-27 at 22 07 14 Simulator Screen Shot - iPhone 12 Pro - 2021-04-27 at 22 05 59

richardtop commented 3 years ago

Could you please share minimal project (e.g. create a new one) which reproduces the issue? I cannot reproduce it in my setup. Just attach it to this issue as a zip archive.

spiccinocchi commented 3 years ago

Sorry it was my mistake, the issue is not present and the localization work great!