richelbilderbeek / djog_unos_2018

Project by the Uno's at DJOG 2018-2019: Nature Zen
GNU General Public License v3.0
6 stars 2 forks source link

Allow player to zoom in and out smoothly #501

Closed richelbilderbeek closed 5 years ago

richelbilderbeek commented 5 years ago

Depends on:

Is your feature request related to a problem? Please describe.

Currently, we use an SFML view (#496) but do not take it into account of all our calculations/transformations (#498). If the latter Issue is done, it should be easy to allow the player to zoom in and out.

Describe the solution you'd like

Let the player zoom in and out with, say, z and c (I reserve q and e for rotation).

Describe alternatives you've considered

None.

Additional context

None.

DynCoder commented 5 years ago

also with scrolling would be nice

richelbilderbeek commented 5 years ago

You mean: 'player should be able to zoom in and out fluidly'?

DynCoder commented 5 years ago

kinda

DynCoder commented 5 years ago

take for example how the scrolling on this very webpage works

DynCoder commented 5 years ago

(in chrome, dont know about duckduckgo scrolling)

richelbilderbeek commented 5 years ago

Renamed Issue :+1:

DynCoder commented 5 years ago

Wouldn't Z and X make more sense? Or . and ,? Leaving the keybind up to the person who does this issue (but make sure to tell me because i document all of the keybinds)

DynCoder commented 5 years ago

Do this after #502

DynCoder commented 5 years ago

The sfml version on travis has to be updated first

richelbilderbeek commented 5 years ago

To quote me:

Basically we are stuck with the current SFML version on Travis [1]. I use this trick:

  #if(SFML_VERSION_MINOR > 3)
  // Newer version
  m_header.setFillColor(sf::Color::Magenta);
  m_header.setOutlineColor(sf::Color::Green);
  m_header.setOutlineThickness(5);
  #else
  // Older version
  //Only relevant for Travis
  m_header.setColor(sf::Color::Green);
  #endif

On Travis, you may consider #if-ing out the code that uses the latest SFML stuff.

richelbilderbeek commented 5 years ago

I do not since when this is available, but we could start using the new Xenial distro, according to the Travis documentation!

richelbilderbeek commented 5 years ago

The status of this Issue is unclear to me. I'll just unassign everyone :smirk: